Can't get normal urls for tags view when using SH404SEF

ggppdk
Offline
Administrator

5 years 9 months ago #74028 by ggppdk

Replied by ggppdk on topic Can't get normal urls for tags view

Hello

i have made a fix 6 days ago

I know you are watching Github commits

Unfortunately the commit name was ...
[WIP] More J4 compatibility, replacing deprecated methods, and classes, also some HTML validity changes

usually trying to avoid irrelevant changes in commits but not always done

-- Flexicontent is Free but involves a big effort on our part.
Like the our support? (for a bug-free FC, despite having a long list of functions) Like the features? Like the ongoing development and future commitment to FLEXIcontent?
-- Add your voice to the FLEXIcontent JED listing with a 5-star...

Please Log in or Create an account to join the conversation.

lipatovroman
Topic Author
Away
Platinum Member

5 years 9 months ago #74029 by lipatovroman

Replied by lipatovroman on topic Can't get normal urls for tags view

ggppdk wrote: Hello

i have made a fix 6 days ago

I know you are watching Github commits

Unfortunately the commit name was ...
[WIP] More J4 compatibility, replacing deprecated methods, and classes, also some HTML validity changes
usually trying to avoid irrelevant changes in commits but not always done

Ok, I have redownloaded last version from github.
Yes, it seem categories URLs are fixed.

But I have last issue.

I added language in /components/com_flexicontent/sef_ext/lang/com_flexicontent.php

Code:

// russian
$sh_LANG ['ru'] ['_SH404SEF_FLEXICONTENT_CONTENT_PAGE']='content page';
$sh_LANG ['ru'] ['_SH404SEF_FLEXICONTENT_FAVOURITES'] = 'My favourites';
$sh_LANG ['ru'] ['_SH404SEF_FLEXICONTENT_SEARCH'] = 'Search';
$sh_LANG ['ru'] ['_SH404SEF_FLEXICONTENT_TAGS'] = 'Tags';
$sh_LANG ['ru'] ['_SH404SEF_FLEXICONTENT_DIRECTORY'] = 'Directory';
$sh_LANG ['ru'] ['_SH404SEF_FLEXICONTENT_ITEM'] = 'Item';
$sh_LANG ['ru'] ['_SH404SEF_FLEXICONTENT_EDIT'] = 'Edit';
$sh_LANG ['ru'] ['_SH404SEF_FLEXICONTENT_ADD'] = 'Add';
$sh_LANG ['ru'] ['_SH404SEF_FLEXICONTENT_DOWNLOAD'] = 'Download';
$sh_LANG ['ru'] ['_SH404SEF_FLEXICONTENT_WEBLINK'] = 'Weblink';
$sh_LANG ['ru'] ['_SH404SEF_FLEXICONTENT_TAGGED'] = 'tags';
$sh_LANG ['ru'] ['_SH404SEF_FLEXICONTENT_AUTHORED'] = 'Authored';
$sh_LANG ['ru'] ['_SH404SEF_FLEXICONTENT_FAVOURED'] = 'Favoured';
$sh_LANG ['ru'] ['_SH404SEF_FLEXICONTENT_MYITEMS'] = 'MyItems';
$sh_LANG ['ru'] ['_SH404SEF_FLEXICONTENT_MCATS'] = 'Categories';

And now urls for tags look as:

content-page/tags/tags/sometag

but it should displays as

tags/sometag

How to fix it?

Please Log in or Create an account to join the conversation.

ggppdk
Offline
Administrator

5 years 9 months ago #74031 by ggppdk

Replied by ggppdk on topic Can't get normal urls for tags view

Ok

unfortunately the file is always overwritten
you can give me suggest some translations and i will check and add them

the translations you gave above are still in english

Please Log in or Create an account to join the conversation.

lipatovroman
Topic Author
Away
Platinum Member

5 years 9 months ago - 5 years 9 months ago #74033 by lipatovroman

Replied by lipatovroman on topic Can't get normal urls for tags view

ggppdk wrote: Ok

unfortunately the file is always overwritten
you can give me suggest some translations and i will check and add them
the translations you gave above are still in english

Issue is not in file.
Issue with URls for tags.

When sh404sef disabled - tags have normal URLs -
menu-alias/101-sometag

When sh404sef enabled
content-page/tags/tags/sometag

So, sh404sef makes normal tags URLs - bad.

We don't need "content-page" in URLs for tags
And we don't need duplicated tags/tags in URLs.

Last edit: 5 years 9 months ago by lipatovroman.

Please Log in or Create an account to join the conversation.

lipatovroman
Topic Author
Away
Platinum Member

5 years 9 months ago #74038 by lipatovroman

Replied by lipatovroman on topic Can't get normal urls for tags view

Please, help...

Please Log in or Create an account to join the conversation.

ggppdk
Offline
Administrator

5 years 9 months ago #74041 by ggppdk

Replied by ggppdk on topic Can't get normal urls for tags view

Hello

i would rather implement removal of IDs for our router
which i will mark as it as "ALPHA" or "BETA" feature so that people do not enable blindly or complain it does not work in all cases

Please Log in or Create an account to join the conversation.