Field Group collapsed in edit form for single value option

bytekultur
Topic Author
Offline
Premium Member

6 years 4 months ago - 6 years 4 months ago #74335 by bytekultur

Field Group collapsed in edit form for single value option was created by bytekultur

Hi, I have a large form and want to use the field group feature to not only structure the display, but also the form.
I would like to use the "start collapsed" option for groups even if they don't allow multiple values.
In plugins/flexicontent_fields/fieldgroup/fieldgroup.php, my suggestion is to replace line 309 with this:

Code:

if($compact_edit==1){
   $js .= "
   jQuery(document).ready(function(){
      toggler = jQuery('#sortables_".$field->id."_hide_vals_btn');
      toggler.trigger('click');
   });
   ";
}

It's just a copy of the code you use in the section only for multiple value groups. I have done it and it works, but obviously it's a core hack and won't last without manual maintenance. Can you imagine adding this to the core, or does it interfere with something I haven't thought of?

Kind regards,
Terry

Last edit: 6 years 4 months ago by bytekultur.

Please Log in or Create an account to join the conversation.

micker
Offline
Administrator

6 years 4 months ago #74342 by micker

Replied by micker on topic Field Group collapsed in edit form for single value option

maybe you can propose a pr on github ? its more simple to use

FLEXIcontent is Free but involves a very big effort on our part.
Like the our support? (for a bug-free FC, despite being huge extension) Like the features? Like the ongoing development and future commitment to FLEXIcontent?
-- Add your voice to the FLEXIcontent JED listing reviews. Thanks![/size]

Please Log in or Create an account to join the conversation.

ggppdk
Offline
Administrator

6 years 4 months ago - 6 years 4 months ago #74343 by ggppdk

Replied by ggppdk on topic Field Group collapsed in edit form for single value option

Hello

thanks for bringing this up
i agree it make sense and collapse behavior
and change should be trivial, (and then some testing too)

About GitHub, only register to GitHub if not already having an account
and
either create a new issue with description of this topic
or submit a PR

-- Flexicontent is Free but involves a big effort on our part.
Like the our support? (for a bug-free FC, despite having a long list of functions) Like the features? Like the ongoing development and future commitment to FLEXIcontent?
-- Add your voice to the FLEXIcontent JED listing with a 5-star...

Last edit: 6 years 4 months ago by ggppdk.

Please Log in or Create an account to join the conversation.