extra SPAN is added by fieldgroup in v3.0.8

More
9 years 1 month ago - 9 years 1 month ago #57042 by despair
Hi ggppdk
I upgrade to FC3.0.8
I use filed group display customized output html

and this is prefix setting


but the output code will wrap with <span ">



this problem is not show in FC3.0.7


Last edit: 9 years 1 month ago by ggppdk.

Please Log in or Create an account to join the conversation.

More
9 years 1 month ago #57049 by ggppdk
Hello

it is probably because of the changes to add microdata

v3.0.8 adds microdata support
- most field types get "itemprop" (parameter inside the SEO TAB)
- in type / item / category / fieldgroup field configuration, you can set the "itemtype" microdata

but the span should not be added unless microdata of fieldgroup is set to some itemtype
will reread your post tomorrow and check for appropriate behaviour


-- Flexicontent is Free but involves a big effort on our part.
Like the our support? (for a bug-free FC, despite having a long list of functions) Like the features? Like the ongoing development and future commitment to FLEXIcontent?
-- Add your voice to the FLEXIcontent JED listing with a 5-star...
The following user(s) said Thank You: despair

Please Log in or Create an account to join the conversation.

More
9 years 1 month ago #57061 by bobthebob01
I confirm the issue on my side as well.

First, there is a typo, a missing quote mark. On line 397
Code:
$pretext = '<span '.$fieldgroup_itemtype_code.'" >'.$pretext;
when it should be
Code:
$pretext = '<span "'.$fieldgroup_itemtype_code.'" >'.$pretext;

Also, I looked an all my field and fieldgroup have no micro data setting set. I actually can see that the fieldgroup micro data option does not have a "Disable" one. Where other fields have.

I guess a check should be done to see if there is any micro data enable. And if nothing, to not show any thing.

I'm gonna remove it manually for now.

Cheers

Please Log in or Create an account to join the conversation.

More
9 years 1 month ago #57086 by ggppdk
Hello

a more correct would be to remove the extra " at the end,

but the actual fix is:
replace:
Code:
$pretext = '<span '.$fieldgroup_itemtype_code.'" >'.$pretext; $posttext = $posttext.'</span>';

with:
Code:
if ($fieldgroup_itemtype_code) { $pretext = '<span '.$fieldgroup_itemtype_code.' >'.$pretext; $posttext = $posttext.'</span>'; }


-- Flexicontent is Free but involves a big effort on our part.
Like the our support? (for a bug-free FC, despite having a long list of functions) Like the features? Like the ongoing development and future commitment to FLEXIcontent?
-- Add your voice to the FLEXIcontent JED listing with a 5-star...

Please Log in or Create an account to join the conversation.

Moderators: vistamediajoomlacornerggppdk
Time to create page: 0.299 seconds
Save
Cookies user preferences
We use cookies to ensure you to get the best experience on our website. If you decline the use of cookies, this website may not function as expected.
Accept all
Decline all
Essential
These cookies are needed to make the website work correctly. You can not disable them.
Display
Accept
Analytics
Tools used to analyze the data to measure the effectiveness of a website and to understand how it works.
Google Analytics
Accept
Decline