Icons container on category appears even when is empty

jrodgar
Topic Author
Offline
Platinum Member

10 years 10 months ago #44076 by jrodgar

Icons container on category appears even when is empty was created by jrodgar

com_flexicontent/tmpl_common/category.php

Code:

	<?php
	if ( $this->params->get('show_print_icon')
		|| $this->params->get('show_email_icon')
		|| JRequest::getCmd('print')
		|| $this->params->get('show_feed_icon', 1)
		|| $this->params->get('show_addbutton', 1)
		) {
	?>

This if means that the next container, "buttons" will appear even when we are not logged on the front end. Thats because the "add button" will only appear if we have the aproppiate permissions, but the check to add it is global. Proposed solution:

Code:

	<?php
	if ( $this->params->get('show_print_icon')
		|| $this->params->get('show_email_icon')
		|| JRequest::getCmd('print')
		|| $this->params->get('show_feed_icon', 1)
		|| ($this->params->get('show_addbutton', 1) && flexicontent_html::addbutton( $this->params, $this->category ))
		) {
	?>

Unless otherwise indicated:
Joomla 3.8.1
Flexicontent 3.2.1.7

Please Log in or Create an account to join the conversation.

ggppdk
Offline
Administrator

10 years 10 months ago #44082 by ggppdk

Replied by ggppdk on topic Icons container on category appears even when is empty

Hello

thanks for suggestion and for providing the suggested code
(it makes quicker to locate what you are suggesting)

will commit this change for next version, but with a bit more appropriate code (calculate addbutton once)

Regards

-- Flexicontent is Free but involves a big effort on our part.
Like the our support? (for a bug-free FC, despite having a long list of functions) Like the features? Like the ongoing development and future commitment to FLEXIcontent?
-- Add your voice to the FLEXIcontent JED listing with a 5-star...

Please Log in or Create an account to join the conversation.