Thoughts about Group Markers

Hi,

Thanks for this it's a very handy feature, three thoughts :

a) It would be cool to have a field called tab-set:FIRST-TAB-START that would stand for tab-set:START + tab-set:open. (Same for closing field and fieldset of course).

So instead of having :

tab-set:START
tab-set:open
content1
tab-set:close
tab-set:open
content2
tab-set:close
tab-set:STOP

you get :

tab-set:FIRST-TAB-OPEN
content1
tab-set:close
tab-set:open
content2
tab-set:LAST-TAB-CLOSE


Advantages are obvious : easier, faster, less human errors.

b) In admin list fields view, the field type is generic for each groupmarker, it's just "Groupmarker - Group marker", not "Groupmarker - tab-open" so it is hard to sort fields or to check if the order is correct.

c) Do you need help to give tabs a nice design ?

about (a) what you suggest was thought, has been thought quite a few times, before deciding to do it this way, for a couple of reasons the current design was chosen, we even though to do a simpler design:

TAB-start
-- fields
TAB-next
-- fields
TAB-next
-- fields
TAB-end

but it caused complexity with information accounting of nested tabs

about what you suggest it seems that indeed would have been best choice with no accounting problem and more human friendly

but to change this now and remove the, would mean breaking compatibility, and if we change it and leave old options available too then it will cause confusion,

(b) yes it is easy code is already there, done

(c) yes you can suggest CSS,
about using different tab mechanism, not possible now we would have to update validation.js too if we change tab mechanism, since we need to focus on invalid fields in the item form

a) I know it's not a good thing to break things in a RC but since you will have to do this one day, better do it sooner.

About compatibility a good solution good be an option in the field to toggle the "marker type" dropwown between "new" and "legacy" (by default).
Not very clean though, but definitly better for the final release.

b) Excellent

c) I'll try to send a nice piece of css.

Thanks

Rewrote/cleaned item's manager RE-ordering code and add to it drag & drop reordering and then one click save,

You can test experimental build RC9b 1590:

SVN Downloads

I guess the drag and drop will benefit fields manager too, where we need to easily shape frontend forms,

anyway with experience in items manager where it was a lot more complex, it will be much easier to add there too (item manager has ordering grouping per category + per publication state + per language)