[Resolved]RC9a (r1549) dble message on approval request

akd01
Topic Author
Offline
Junior Member

11 years 11 months ago - 11 years 11 months ago #31267 by akd01

[Resolved]RC9a (r1549) dble message on approval request was created by akd01

Hi,

I'm on Joomla 2.5.8, Flexi 2.0.0 RC9a (r1549).
Main language of the website is "French".
Install on a clean version (from scratch).

When i'm sending an approval request for 1 content in back office, the request is well send, but I have a double message; 1 telling a content is put on approval and 1 telling a content was excluded.

In french the exact message is:

1 élément soumis à approbation. 1 éléments exclus*.
* Attention!!! Vous ne pouvez soumettre à approbation que vos PROPRES articles, et uniquement ceux qui sont à l'état 'BROUILLON'.

I saw there was a full refunding on this feature, I don't know if there's a problem specific to my site (I had problems on a test version before with joomsef and the 404 content it adds automatically) or if somebody else had the same behavior.

Last edit: 11 years 11 months ago by akd01.

Please Log in or Create an account to join the conversation.

ggppdk
Offline
Administrator

11 years 11 months ago #31268 by ggppdk

Replied by ggppdk on topic [Resolved]RC9a (r1549) dble message on approval request

Please change language to english and retest, so that i can see if problem is program logic or language string

(copy paste english messages here)

-- Flexicontent is Free but involves a big effort on our part.
Like the our support? (for a bug-free FC, despite having a long list of functions) Like the features? Like the ongoing development and future commitment to FLEXIcontent?
-- Add your voice to the FLEXIcontent JED listing with a 5-star...

Please Log in or Create an account to join the conversation.

akd01
Topic Author
Offline
Junior Member

11 years 11 months ago #31274 by akd01

Replied by akd01 on topic [Resolved]RC9a (r1549) dble message on approval request

i've retested. Still with 1 content to approve, I have these messages :

French (I rewrite it because I saw I've forgotten to keep the 1st character of the message):

11 élément soumis à approbation. 1 éléments exclus*.
* Attention!!! Vous ne pouvez soumettre à approbation que vos PROPRES articles, et uniquement ceux qui sont à l'état 'BROUILLON'.

English :

11 item submitted for approval. 1 items excluded (*).
* Take care!!! You can only require approval for your OWN items and only those which states are 'DRAFT'.

So I have the same problem in both languages.

I have more than 11 contents/items made in my website and 8-9 contents in the category I put the contents I've submitted.

Please Log in or Create an account to join the conversation.

ggppdk
Offline
Administrator

11 years 11 months ago #31299 by ggppdk

Replied by ggppdk on topic [Resolved]RC9a (r1549) dble message on approval request

Hello i found and fixing the approval result message code.

To try/test fix now:

in administrator/components/com_flexicontent/models/parentitemclass.php

Replace

Code:

// Number of submitted items
if ( $submitted) {
	$approve_str = submitted > 1 ? 'FLEXI_APPROVAL_ITEMS_SUBMITTED' : 'FLEXI_APPROVAL_ITEM_SUBMITTED';
	$msg = $submitted . JText::_( $approve_str ) .' '. $msg;
} else {
	$msg = JText::_( 'FLEXI_APPROVAL_NO_ITEMS_SUBMITTED' );
}

// Number of excluded items, and message that items must be owned and in draft state
$excluded = count($cid) - submitted;
$msg .= $excluded  ?  ' '. $excluded .' '. JText::_( 'FLEXI_APPROVAL_ITEMS_EXCLUDED' )  :  '';

with:

Code:

// Number of submitted items
if ( $submitted) {
	$approve_str = $submitted > 1 ? 'FLEXI_APPROVAL_ITEMS_SUBMITTED' : 'FLEXI_APPROVAL_ITEM_SUBMITTED';
	$msg = ($submitted > 1 ? $submitted : '') . JText::_( $approve_str );
} else {
	$msg = JText::_( 'FLEXI_APPROVAL_NO_ITEMS_SUBMITTED' );
}
	
// Number of excluded items, and message that items must be owned and in draft state
$excluded = count($cid) - $submitted;
$msg .= $excluded  ?  ' '. $excluded .' '. JText::_( 'FLEXI_APPROVAL_ITEMS_EXCLUDED' )  :  '';

Please Log in or Create an account to join the conversation.