Open menu

[fixed r1366] FC content module bug with "Tags scope"

hede
Topic Author
Offline
Platinum Member

12 years 4 months ago #26468 by hede

Replied by hede on topic [fixed r1366] FC content module bug with "Tags scope"

Thanks. Works great.

FF on Win10, FLEXIcontent version 3.0.10 on Joomla 3.4

Please Log in or Create an account to join the conversation.

hede
Topic Author
Offline
Platinum Member

12 years 4 months ago #26562 by hede

Replied by hede on topic [fixed r1366] FC content module bug with "Tags scope"

Since around r1363 the old behavior is back - if there is only one single item with the tag the module goes crazy and displays all items with all the other tags except the one with the specified tag (as descriped above).

FF on Win10, FLEXIcontent version 3.0.10 on Joomla 3.4

Please Log in or Create an account to join the conversation.

ggppdk
Offline
Administrator

12 years 4 months ago #26571 by ggppdk

Replied by ggppdk on topic [fixed r1366] FC content module bug with "Tags scope"

I think it was never fixed 100%, i found the problem: = AND <> are reversed when there is a single item

In modules/mod_flexicontent/helper.php
Find lines:

Code:

$where .= (count($tagged) > 1) ? ' AND i.id NOT IN ('.implode(',', $tagged).')' : ' AND i.id = '.$tagged[0];
...
$where .= (count($tagged) > 1) ? ' AND i.id IN ('.implode(',', $tagged).')' : ' AND i.id <> '.$tagged[0];

and replace with:

Code:

$where .= (count($tagged) > 1) ? ' AND i.id NOT IN ('.implode(',', $tagged).')' : ' AND i.id <> '.$tagged[0];
...
$where .= (count($tagged) > 1) ? ' AND i.id IN ('.implode(',', $tagged).')' : ' AND i.id = '.$tagged[0];

I will commit the fix

-- Flexicontent is Free but involves a big effort on our part.
Like the our support? (for a bug-free FC, despite having a long list of functions) Like the features? Like the ongoing development and future commitment to FLEXIcontent?
-- Add your voice to the FLEXIcontent JED listing with a 5-star...

Please Log in or Create an account to join the conversation.