Add/Adjust Filter Labels

More
2 years 8 months ago #82101 by krae
When evaluating accessibility, I have been getting errors in regards to filters that they are missing related labels and I'm wondering if that's something that can be fixed in the next release?  Or if you may have any other suggestions?  It's possible that this was fixed for Joomla 47, but I haven't used it yet.

In filters.php on line 132, I adjusted the div for the text search that was working as a label to: <label class="fc_filter_label" for="adminForm_filter"><?php echo JText::_('FLEXI_TEXT_SEARCH'); ?></label>

I did the same on line 262 for the other field filters: <label class="fc_filter_label fc_label_field_'.$filt->id.'" for="adminForm_'.$filt->id.'_val">' .$filt_lbl. '</label>'

The Order By filter was also causing the same issue, so in listings_filter_form_body.php on line 58, I adjusted it to: <?php if ($orderby_selector_2nd) echo '<div class="label fc_orderby_level_lbl">1</div>'; ?> <label for="orderby" hidden >Order By</label><div class="fc_orderby_selector"><?php echo $orderby_selector;?></div>

I imagine there is a better option for the Order By filter to have the label text change on multilingual sites, but this was a quick fix for now.

Flexi 3.3.11
Joomla 3.10.8

Thanks
 

Please Log in or Create an account to join the conversation.

More
2 years 8 months ago #82104 by micker
Replied by micker on topic Add/Adjust Filter Labels
can you make a PR ? i will review it and include in core ?

FLEXIcontent is Free but involves a very big effort on our part.
Like the our support? (for a bug-free FC, despite being huge extension) Like the features? Like the ongoing development and future commitment to FLEXIcontent?
-- Add your voice to the FLEXIcontent JED listing reviews. Thanks![/size]

Please Log in or Create an account to join the conversation.

Moderators: vistamediajoomlacornerggppdk
Time to create page: 0.807 seconds
Save
Cookies user preferences
We use cookies to ensure you to get the best experience on our website. If you decline the use of cookies, this website may not function as expected.
Accept all
Decline all
Essential
These cookies are needed to make the website work correctly. You can not disable them.
Display
Accept
Analytics
Tools used to analyze the data to measure the effectiveness of a website and to understand how it works.
Google Analytics
Accept
Decline