Category language filter including JoomFish translations

I wanted to enable the “filter category views” (by language) option on my site, with items that had a published JoomFish translation included amongst the results along with any items identified in FlexiContent as being in the currently selected language. This is not how FlexiContent currently behaves, so I modified components/com_flexicontent/models/category.php to add the necessary logic, and I suggest that this should be the actual behaviour of the “filter category views” option.

Here are the changes I made (context / logic based on v1.5.6 RC1 r967 and v2.0 RC1 r967, and should work with both):

In the file listed above, in the _buildQuery() function, above this line: , I added:
then in the actual creation of the $query string, above the beginning of the ‘where’ part of the query: , I concatenate the string created above to the $query string:
The second part of the change comes in the _buildItemWhere() function, within the if (FLEXI_FISH && $filtercat) { block that comes after this comment: "// Filter the category view with the active active language". I replaced the existing line with one that checks if the language is like $lang OR if it has a published translation in the language $lang (note that the second part of that condition only gets checked if joomfish is currently active [i.e., if (defined('JOOMFISH_PATH'))):
And that’s everything! To me, this seems to be a better, more complete Joomfish integration; if a user has decided to use Joomfish and wants to filter by language, wouldn’t they want translations in the current language to be included?

I hope that is clear, and that the developers will consider including this in the flexicontent core. Thanks!

Thanks, good idea, just in v1.5.7 we will have full items translations associated with the original item, plus Google translation and Joomfish data import

but i have opened an enhancement issue to examine your code:

code.google.com/p/flexicontent/i ... ail?id=289

Great, thanks for the quick response. Making item translations native to flexicontent sounds like an ideal solution for multi-language websites. I hope that goes well.

And thanks also for opening an issue to consider the code I suggested, I hope some version of it makes it in. I think it would help others who still decide, for whatever reason, to use joomfish (e.g. if they only want one interface to translate all of their content, including modules, menu items, contacts, etc.).

Cheers!

HUH, this really saved my day.

I implemented it also in the module (getItems method in the helper), code is almost the same except that if needs to check for $method_curlang == 2 instead of $filtercat, where part comes in the begging of the method, after and join part is added to the query at the end of the method