Regarding soft deny on 3.6.5

More
7 years 9 months ago #65545 by jrodgar
Hi!

I found the problem and your solving commit github.com/FLEXIcontent/flexicontent-cck...8588d6684cb752f7185e but I don´t know why you refer to it as workaround

It is a Joomla mistake? I was planning to make a patch until the next stable release of flexicontent

Unless otherwise indicated:
Joomla 3.8.1
Flexicontent 3.2.1.7

Please Log in or Create an account to join the conversation.

More
7 years 9 months ago - 7 years 9 months ago #65546 by ggppdk
Replied by ggppdk on topic Regarding soft deny on 3.6.5
Hello

JUser::authorise in J3.6.5

will return false instead of NULL in the case of soft deny,
after talking to Joomla issue tracker, the reason for this change was not a bug,

- but to make it match the existing online documentation that was saying it always returns a boolean

It is a problem in existing installations, because they need to be updated
- but from implementation side it is simple to fix, we just use:

JAccess::check()

Maybe workaround is not a proper term,
because in any case the fix is proper and will not break in the future

The reason for the above code is to minimize cost of ADD BUTTON when you use soft deny and you have e.g. 500, 1000, 2000 categories in a website, the calculation needs to re-happen any time the categories cache is cleared
- e.g. global config save or component config save or category config save

PS: i am making a new (testing) build in github
i am now updating its changelog (release) text

You can test it


-- Flexicontent is Free but involves a big effort on our part.
Like the our support? (for a bug-free FC, despite having a long list of functions) Like the features? Like the ongoing development and future commitment to FLEXIcontent?
-- Add your voice to the FLEXIcontent JED listing with a 5-star...
Last edit: 7 years 9 months ago by ggppdk.

Please Log in or Create an account to join the conversation.

More
7 years 9 months ago #65548 by jrodgar
much appreciated. I have made a patch for Flexi 3.1.1 until next update

regards

Unless otherwise indicated:
Joomla 3.8.1
Flexicontent 3.2.1.7

Please Log in or Create an account to join the conversation.

More
7 years 9 months ago - 7 years 9 months ago #65549 by ggppdk
Replied by ggppdk on topic Regarding soft deny on 3.6.5
The patch is the changes made in

components/com_flexicontent/helpers/permission.php

and

1 line removed in (near the top):
administrator/components/com_flexicontent/views/flexicontent/view.html.php


-- Flexicontent is Free but involves a big effort on our part.
Like the our support? (for a bug-free FC, despite having a long list of functions) Like the features? Like the ongoing development and future commitment to FLEXIcontent?
-- Add your voice to the FLEXIcontent JED listing with a 5-star...
Last edit: 7 years 9 months ago by ggppdk.

Please Log in or Create an account to join the conversation.

More
7 years 9 months ago #65552 by jrodgar
I did the changes on getPermAny and modified the helpers to check first "$item->created_by == $user->get('id')"

What line on view.html.php are you refering to?

Unless otherwise indicated:
Joomla 3.8.1
Flexicontent 3.2.1.7

Please Log in or Create an account to join the conversation.

More
7 years 9 months ago #65553 by ggppdk
Replied by ggppdk on topic Regarding soft deny on 3.6.5
Hello

i guess you patched it correctly, but read more here:
www.flexicontent.org/forum/21-troublesho....html?start=10#65551


-- Flexicontent is Free but involves a big effort on our part.
Like the our support? (for a bug-free FC, despite having a long list of functions) Like the features? Like the ongoing development and future commitment to FLEXIcontent?
-- Add your voice to the FLEXIcontent JED listing with a 5-star...

Please Log in or Create an account to join the conversation.

Moderators: vistamediajoomlacornerggppdk
Time to create page: 0.294 seconds
Save
Cookies user preferences
We use cookies to ensure you to get the best experience on our website. If you decline the use of cookies, this website may not function as expected.
Accept all
Decline all
Essential
These cookies are needed to make the website work correctly. You can not disable them.
Display
Accept
Analytics
Tools used to analyze the data to measure the effectiveness of a website and to understand how it works.
Google Analytics
Accept
Decline